-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (mobile) scrolling in lists with pull-to-refresh #1706
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
pullDownThreshold={80} | ||
resistance={2} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increasing the resistance a bit in order to make it more difficult to refresh accidentally
'& .ptr__children': { | ||
overflow: 'hidden auto', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main fix.. a bit hacky.. but I couldn't figure out anything better sadly.
'& .ptr__pull-down': { | ||
textAlign: 'center', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Centers the "pull down to refresh" label that is visible before the refresh starts
* [refactor] Migrate Schedules Table to typescript (actualbudget#1691) * 🔧 removing unnecessary manual module resolution (actualbudget#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (actualbudget#1706) * 💄 (mobile) updating apple home-screen icon (actualbudget#1705) * Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]>
* first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (#1688) * 🎨 fix multiline label in schedules modal (#1687) * Update Visual Regression README File (#1689) * Fix typo in GoCardlessLink.js (#1684) happend -> happened * queried cleared balance for tooltip (#1678) * Dark Theme Reports/Settings (#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (#1698) * 👷 do not cancel github ci jobs on master branch (#1692) * Sidebar Account Fix (#1703) * Dark Theme Final (#1513) * Category autocomplete should only search selectable categories (#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> * update release note * lint * use null as cleared state * show goal status via colors (#41) * cleanup * I think its working * lint * fix the error by adding colors to the report side (#42) * [refactor] Migrate Schedules Table to typescript (#1691) * 🔧 removing unnecessary manual module resolution (#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (#1706) * 💄 (mobile) updating apple home-screen icon (#1705) * Enhance Y-Axis Scaling on Net Worth Graph (#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> * report budget database updates * Fix schedule searchbar (#1729) --------- Co-authored-by: youngcw <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> Co-authored-by: Mohamed Muhsin <[email protected]>
* first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (#1688) * 🎨 fix multiline label in schedules modal (#1687) * Update Visual Regression README File (#1689) * Fix typo in GoCardlessLink.js (#1684) happend -> happened * queried cleared balance for tooltip (#1678) * Dark Theme Reports/Settings (#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (#1698) * 👷 do not cancel github ci jobs on master branch (#1692) * Sidebar Account Fix (#1703) * Dark Theme Final (#1513) * Category autocomplete should only search selectable categories (#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> * update release note * lint * use null as cleared state * show goal status via colors (#41) * cleanup * I think its working * lint * fix report budget, by adding in the goal coloring * fix the error by adding colors to the report side (#42) * [refactor] Migrate Schedules Table to typescript (#1691) * 🔧 removing unnecessary manual module resolution (#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (#1706) * 💄 (mobile) updating apple home-screen icon (#1705) * Enhance Y-Axis Scaling on Net Worth Graph (#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> * report budget database updates * Goal progress bar (#1734) * first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (#1688) * 🎨 fix multiline label in schedules modal (#1687) * Update Visual Regression README File (#1689) * Fix typo in GoCardlessLink.js (#1684) happend -> happened * queried cleared balance for tooltip (#1678) * Dark Theme Reports/Settings (#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (#1698) * 👷 do not cancel github ci jobs on master branch (#1692) * Sidebar Account Fix (#1703) * Dark Theme Final (#1513) * Category autocomplete should only search selectable categories (#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> * update release note * lint * use null as cleared state * show goal status via colors (#41) * cleanup * I think its working * lint * fix the error by adding colors to the report side (#42) * [refactor] Migrate Schedules Table to typescript (#1691) * 🔧 removing unnecessary manual module resolution (#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (#1706) * 💄 (mobile) updating apple home-screen icon (#1705) * Enhance Y-Axis Scaling on Net Worth Graph (#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> * report budget database updates * Fix schedule searchbar (#1729) --------- Co-authored-by: youngcw <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> Co-authored-by: Mohamed Muhsin <[email protected]> * working dynamic colors. Need to figure out what changes are actually needed * cleanup * more cleanup * lint * reset the goal when applying a single template * make getCategory function * remove some unneeded changes * actually remove the changes, not just comment * cleanup some unneeded code that was causing some bugs. Works for me, but should be vetted more * lint * add json definitions to database * use template feature flag to enable colors * some fixes * don't set goals for remainders, remove unneeded change * lint * release note * lint again * fix mobile crash * undo changes in CellValue.tsx * lint * use getStyle * move status calc to helper * lint * recommendations * suggestion Co-authored-by: Joel Jeremy Marquez <[email protected]> --------- Co-authored-by: shall0pass <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Joel Jeremy Marquez <[email protected]>
…albudget#1780) * first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (actualbudget#1688) * 🎨 fix multiline label in schedules modal (actualbudget#1687) * Update Visual Regression README File (actualbudget#1689) * Fix typo in GoCardlessLink.js (actualbudget#1684) happend -> happened * queried cleared balance for tooltip (actualbudget#1678) * Dark Theme Reports/Settings (actualbudget#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (actualbudget#1698) * 👷 do not cancel github ci jobs on master branch (actualbudget#1692) * Sidebar Account Fix (actualbudget#1703) * Dark Theme Final (actualbudget#1513) * Category autocomplete should only search selectable categories (actualbudget#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> * update release note * lint * use null as cleared state * show goal status via colors (actualbudget#41) * cleanup * I think its working * lint * fix report budget, by adding in the goal coloring * fix the error by adding colors to the report side (actualbudget#42) * [refactor] Migrate Schedules Table to typescript (actualbudget#1691) * 🔧 removing unnecessary manual module resolution (actualbudget#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (actualbudget#1706) * 💄 (mobile) updating apple home-screen icon (actualbudget#1705) * Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> * report budget database updates * Goal progress bar (actualbudget#1734) * first pass at progress bar * db migration / enter goal in db * add getGoal function * stabilize * whoops * TS * reset goal in db if no template found * reconfirm * release note * typo * rename migration * to ms * move priority logic, consistent variable names, * fixup * clear goal if template removed * Visual goals (#40) * 🔥 removing privacyMode feature flag (actualbudget#1688) * 🎨 fix multiline label in schedules modal (actualbudget#1687) * Update Visual Regression README File (actualbudget#1689) * Fix typo in GoCardlessLink.js (actualbudget#1684) happend -> happened * queried cleared balance for tooltip (actualbudget#1678) * Dark Theme Reports/Settings (actualbudget#1512) * 🐛 Mobile account transaction list: Fix sticky date section headers (actualbudget#1698) * 👷 do not cancel github ci jobs on master branch (actualbudget#1692) * Sidebar Account Fix (actualbudget#1703) * Dark Theme Final (actualbudget#1513) * Category autocomplete should only search selectable categories (actualbudget#1681) * set colors based on a goal value * extra comment --------- Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> * update release note * lint * use null as cleared state * show goal status via colors (actualbudget#41) * cleanup * I think its working * lint * fix the error by adding colors to the report side (actualbudget#42) * [refactor] Migrate Schedules Table to typescript (actualbudget#1691) * 🔧 removing unnecessary manual module resolution (actualbudget#1707) * 🐛 (mobile) scrolling in lists with pull-to-refresh (actualbudget#1706) * 💄 (mobile) updating apple home-screen icon (actualbudget#1705) * Enhance Y-Axis Scaling on Net Worth Graph (actualbudget#1709) * fix report budget, by adding in the goal coloring --------- Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> * report budget database updates * Fix schedule searchbar (actualbudget#1729) --------- Co-authored-by: youngcw <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> Co-authored-by: Mohamed Muhsin <[email protected]> * working dynamic colors. Need to figure out what changes are actually needed * cleanup * more cleanup * lint * reset the goal when applying a single template * make getCategory function * remove some unneeded changes * actually remove the changes, not just comment * cleanup some unneeded code that was causing some bugs. Works for me, but should be vetted more * lint * add json definitions to database * use template feature flag to enable colors * some fixes * don't set goals for remainders, remove unneeded change * lint * release note * lint again * fix mobile crash * undo changes in CellValue.tsx * lint * use getStyle * move status calc to helper * lint * recommendations * suggestion Co-authored-by: Joel Jeremy Marquez <[email protected]> --------- Co-authored-by: shall0pass <[email protected]> Co-authored-by: Matiss Janis Aboltins <[email protected]> Co-authored-by: Crazypkr1099 <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]> Co-authored-by: Shaan Khosla <[email protected]> Co-authored-by: Neil <[email protected]> Co-authored-by: Trevor Farlow <[email protected]> Co-authored-by: Mohamed Muhsin <[email protected]> Co-authored-by: Joel Jeremy Marquez <[email protected]>
Closes #1699